netdev - Re: [net PATCH 1/1] qlge:Changing netdev msg level to default debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Jan 2012 11:52:19 -0500
From:	Viral Mehta <viral.vkm@...il.com>
To:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, ron.mercer@...gic.com,
	Dept_NX_Linux_NIC_Driver <Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: Re: [net PATCH 1/1] qlge:Changing netdev msg level to default debug

Hi,

On Mon, Jan 23, 2012 at 6:38 PM, Jitendra Kalsaria
<jitendra.kalsaria@...gic.com> wrote:

> -static const u32 default_msg =
> -    NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK |
> -/* NETIF_MSG_TIMER |   */
> -    NETIF_MSG_IFDOWN |
> -    NETIF_MSG_IFUP |
> -    NETIF_MSG_RX_ERR |
> -    NETIF_MSG_TX_ERR |
> -/*  NETIF_MSG_TX_QUEUED | */
> -/*  NETIF_MSG_INTR | NETIF_MSG_TX_DONE | NETIF_MSG_RX_STATUS | */
> -/* NETIF_MSG_PKTDATA | */
> -    NETIF_MSG_HW | NETIF_MSG_WOL | 0;
> -
> -static int debug = -1; /* defaults above */
> +#define DEFAULT_DEBUG_MSG_LEVEL 3
> +static int debug = DEFAULT_DEBUG_MSG_LEVEL;
>  module_param(debug, int, 0664);
>  MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
>
> @@ -4614,7 +4603,7 @@ static int __devinit ql_init_device(struct pci_dev *pdev,
>                err = -EIO;
>                goto err_out2;
>        }
> -       qdev->msg_enable = netif_msg_init(debug, default_msg);
> +       qdev->msg_enable = netif_msg_init(debug, DEFAULT_DEBUG_MSG_LEVEL);

Do you want to initialize qdev->msg_enable with 0x11 ?
(I assume this based on above line where you initialized debug with 3
(decimal value))

If so, the above line will initialize with 0x111
As per netif_msg_init function (1 << 3 ) -1

Poiniting out because it can be a mistake in hurry.
If not, and you think what you have done is
what you wanted to do then sorry for the noise

But would like to read more clear commit log message.

-- 
Thanks,
Viral Mehta
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html