netdev - Re: Backtrace in rds code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Jan 2012 19:26:25 -0500
From:	Josh Boyer <jwboyer@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	venkat.x.venkatsubra@...cle.com, netdev@...r.kernel.org
Subject: Re: Backtrace in rds code

On Tue, Jan 24, 2012 at 5:04 PM, David Miller <davem@...emloft.net> wrote:
>
> Please try this patch:
>
> --------------------
> rds: Make rds_sock_lock BH rather than IRQ safe.
>
> rds_sock_info() triggers locking warnings because we try to perform a
> local_bh_enable() (via sock_i_ino()) while hardware interrupts are
> disabled (via taking rds_sock_lock).
>
> There is no reason for rds_sock_lock to be a hardware IRQ disabling
> lock, none of these access paths run in hardware interrupt context.
>
> Therefore making it a BH disabling lock is safe and sufficient to
> fix this bug.
>
> Reported-by: Kumar Sanghvi <kumaras@...lsio.com>
> Reported-by: Josh Boyer <jwboyer@...il.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>

Using the same base kernel as I did to report the issue, plus this patch the
issue seems to be gone.  I can't really claim rds works overall, but the oops
output is definitely cleared up.

Thanks for such a quick turn around.

josh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html