netdev - Re: [PATCH 1/1] l2tp: l2tp_ip - fix possible oops on packet receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 25 Jan 2012 21:45:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	jchapman@...alix.com, netdev@...r.kernel.org, alex@....org,
	ben@...adent.org.uk
Subject: Re: [PATCH 1/1] l2tp: l2tp_ip - fix possible oops on packet receive

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 25 Jan 2012 14:06:57 +0100

> Le mercredi 25 janvier 2012 à 12:39 +0000, James Chapman a écrit :
>> When a packet is received on an L2TP IP socket (L2TPv3 IP link
>> encapsulation), the l2tpip socket's backlog_rcv function calls
>> xfrm4_policy_check(). This is not necessary, since it was called
>> before the skb was added to the backlog. With CONFIG_NET_NS enabled,
>> xfrm4_policy_check() will oops if skb->dev is null, so this trivial
>> patch removes the call.
>> 
>> This bug has always been present, but only when CONFIG_NET_NS is
>> enabled does it cause problems. Most users are probably using UDP
>> encapsulation for L2TP, hence the problem has only recently
>> surfaced.
>> 
> ...
>> Signed-off-by: James Chapman <jchapman@...alix.com>
>> 
>> ---
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: alex <alex@....org>
> Cc: Ben Hutchings <ben@...adent.org.uk>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html