netdev - Re: [PATCH net-next 3/7] r8169: stop delaying workqueue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Jan 2012 13:20:13 -0800
From:	Joe Perches <joe@...ches.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Hayes Wang <hayeswang@...ltek.com>
Subject: Re: [PATCH net-next 3/7] r8169: stop delaying workqueue.

On Fri, 2012-01-27 at 21:56 +0100, Francois Romieu wrote:
> Though motivated by the move of the driver to a single work queue of
> sequential events and removal of hard irq processing, it looks safe as
> a standalone change.
[]
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
[]
> @@ -714,7 +714,11 @@ struct rtl8169_private {
>  	unsigned int (*phy_reset_pending)(struct rtl8169_private *tp);
>  	unsigned int (*link_ok)(void __iomem *);
>  	int (*do_ioctl)(struct rtl8169_private *tp, struct mii_ioctl_data *data, int cmd);
> -	struct delayed_work task;
> +
> +	struct {
> +		struct work_struct work;
> +	} wk;

This struct is usefully expanded in patch 7/7.

Perhaps this should be mentioned in the changelog
otherwise the change looks rather suspect.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html