netdev - Re: [PATCH net-next 6/7] r8169: missing barriers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Jan 2012 10:06:46 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Hayes Wang <hayeswang@...ltek.com>
Subject: Re: [PATCH net-next 6/7] r8169: missing barriers.

Le vendredi 27 janvier 2012 à 21:58 +0100, Francois Romieu a écrit :
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Cc: Hayes Wang <hayeswang@...ltek.com>
> ---
>  drivers/net/ethernet/realtek/r8169.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 610f4b3..8dd13f5 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -5552,7 +5552,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
>  
>  	if (TX_BUFFS_AVAIL(tp) < MAX_SKB_FRAGS) {
>  		netif_stop_queue(dev);
> -		smp_rmb();
> +		smp_mb();
>  		if (TX_BUFFS_AVAIL(tp) >= MAX_SKB_FRAGS)
>  			netif_wake_queue(dev);
>  	}
> @@ -5653,7 +5653,7 @@ static void rtl8169_tx_interrupt(struct net_device *dev,
>  
>  	if (tp->dirty_tx != dirty_tx) {
>  		tp->dirty_tx = dirty_tx;
> -		smp_wmb();
> +		smp_mb();
>  		if (netif_queue_stopped(dev) &&
>  		    (TX_BUFFS_AVAIL(tp) >= MAX_SKB_FRAGS)) {
>  			netif_wake_queue(dev);
> @@ -5664,7 +5664,6 @@ static void rtl8169_tx_interrupt(struct net_device *dev,
>  		 * of start_xmit activity is detected (if it is not detected,
>  		 * it is slow enough). -- FR
>  		 */
> -		smp_rmb();
>  		if (tp->cur_tx != dirty_tx)
>  			RTL_W8(TxPoll, NPQ);
>  	}

It would be good changelog explains the rationale, or you add comments
in the code.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html