netdev - Re: [PATCH] net: Disambiguate kernel message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jan 2012 20:22:03 -0800
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Arun Sharma <asharma@...com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	Glauber Costa <glommer@...allels.com>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] net: Disambiguate kernel message

On Mon, Jan 30, 2012 at 2:41 PM, Arun Sharma <asharma@...com> wrote:
> Some of our machines were reporting:
>
> TCP: too many of orphaned sockets
>
> even when the number of orphaned sockets was well below the
> limit.
>
> We print a different message depending on whether we're out
> of TCP memory or there are too many orphan sockets.

This patch mentions pairs of messages that are almost the same, but
not quite.  If they're supposed to be different, I'd suggest making
them clearly different.  As it is, the differences look like careless
mistakes:

>                                printk(KERN_INFO "TCP: too many of orphaned "
>                                       "sockets\n");
> +                       printk(KERN_INFO "TCP: too many orphaned sockets\n");

> +                               printk(KERN_INFO "TCP: out of memory. "
> +                                      "Consider tuning tcp_mem\n");
>                        printk(KERN_INFO "Out of socket memory\n");

"too many orphaned sockets" is better English usage than "too many of ..."

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html