netdev - Re: brcm80211 breakage..

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Jan 2012 13:08:46 +0100
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"John W. Linville" <linville@...hat.com>,
	Network Development <netdev@...r.kernel.org>,
	Rafał Miłecki <zajec5@...il.com>
Subject: Re: brcm80211 breakage..

Hi Linus,

Thanks for the MBA31 fixes. Sadly, however, with current git
(27ba234), after encountering the known problem

[  882.064120] bcma: Failed to get SPROM: -71

probing simply fails on my machine,

[  882.064256] bcma-pci-bridge: probe of 0000:01:00.0 failed with error -2

resulting in no wireless. Since the bcma SPROM setup allegedly is
unused, simply ignoring the error with this hack

diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
index febbc0a..cb69fb0 100644
--- a/drivers/bcma/main.c
+++ b/drivers/bcma/main.c
@@ -171,7 +171,6 @@ int bcma_bus_register(struct bcma_bus *bus)
 		pr_err("No SPROM available\n");
 	} else if (err) {
 		pr_err("Failed to get SPROM: %d\n", err);
-		return -ENOENT;
 	}
 
 	/* Register found cores */

makes the device register as

01:00.0 0280: 14e4:4353 (rev 01)
	Subsystem: 106b:00d1
	Kernel driver in use: bcma-pci-bridge

which seems to actually work. Instead of the failed probe, the log shows

[ 1168.048571] bcma: Core 0 found: ChipCommon (manuf 0x4BF, id 0x800, rev 0x22, class 0x0)
[ 1168.048706] bcma: Core 1 found: IEEE 802.11 (manuf 0x4BF, id 0x812, rev 0x17, class 0x0)
[ 1168.048855] bcma: Core 2 found: PCIe (manuf 0x4BF, id 0x820, rev 0x0F, class 0x0)
[ 1168.049051] bcma: Found rev 6 PMU (capabilities 0x108C2606)
[ 1168.120122] bcma: Failed to get SPROM: -71
[ 1168.120340] bcma: Bus registered
[ 1168.125167] brcmsmac bcma0:0: mfg 4bf core 812 rev 23 class 0 irq 23
[ 1168.175670] bcma: Switched to core: 0x812
[ 1168.182061] brcms_module_init: register returned 0

Given that our machines look the same, this is somewhat odd. Could
this be a config issue or did I miss something else?

Henrik
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html