netdev - Re: [PATCH] cgroup: remove cgroup_subsys argument from callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 2 Feb 2012 09:26:11 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	container cgroup <containers@...ts.linux-foundation.org>,
	Cgroups <cgroups@...r.kernel.org>, linux-mm@...ck.org,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] cgroup: remove cgroup_subsys argument from callbacks

On Tue, Jan 31, 2012 at 01:47:36PM +0800, Li Zefan wrote:
> The argument is not used at all, and it's not necessary, because
> a specific callback handler of course knows which subsys it
> belongs to.
> 
> Now only ->pupulate() takes this argument, because the handlers of
> this callback always call cgroup_add_file()/cgroup_add_files().
> 
> So we reduce a few lines of code, though the shrinking of object size
> is minimal.
> 
>  16 files changed, 113 insertions(+), 162 deletions(-)
> 
>    text    data     bss     dec     hex filename
> 5486240  656987 7039960 13183187         c928d3 vmlinux.o.orig
> 5486170  656987 7039960 13183117         c9288d vmlinux.o
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

Nice cleanup, applied to cgroup/for-3.4.  Thank you!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html