lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 05 Feb 2012 11:12:10 -0800 From: Marcel Holtmann <marcel@...tmann.org> To: Al Viro <viro@...IV.linux.org.uk> Cc: linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org, David Miller <davem@...emloft.net> Subject: Re: [PATCH] l2cap_chan_connect() shouldn't be inlined Hi Al, > For one thing, it's big. For another, the only caller is in a different > file anyway... > > Signed-off-by: Al Viro <viro@...iv.linux.org.uk> > > diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h > index 68f5891..124f7cf 100644 > --- a/include/net/bluetooth/l2cap.h > +++ b/include/net/bluetooth/l2cap.h > @@ -834,7 +834,7 @@ int l2cap_add_scid(struct l2cap_chan *chan, __u16 scid); > struct l2cap_chan *l2cap_chan_create(struct sock *sk); > void l2cap_chan_close(struct l2cap_chan *chan, int reason); > void l2cap_chan_destroy(struct l2cap_chan *chan); > -inline int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, > +int l2cap_chan_connect(struct l2cap_chan *chan, __le16 psm, u16 cid, > bdaddr_t *dst); I have no idea on how that happened, but you are fully correct this is pointless. Acked-by: Marcel Holtmann <marcel@...tmann.org> Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists