netdev - Re: [PATCH] bcma: don't fail for bad SPROM CRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Feb 2012 14:48:57 +0100
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Arend van Spriel <arend@...adcom.com>
Cc:	"John W. Linville" <linville@...driver.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	Rafał Miłecki <zajec5@...il.com>
Subject: Re: [PATCH] bcma: don't fail for bad SPROM CRC

On Mon, Feb 06, 2012 at 02:34:08PM +0100, Arend van Spriel wrote:
> On 02/06/2012 02:26 PM, Henrik Rydberg wrote:
> > The brcmsmac driver is now checking the bcma SPROM CRCs, leaving some
> > chipsets unrecognized that were functional prior to the switch. In
> > particular, the current code bails out on recent Macbooks. This patch
> > simply ignores the outcome of the CRC check, with the argument that an
> > unrecognized SPROM should be treated similarly to a non-existing one.
> 
> Suggestion:
> 
> The brcmsmac driver is now registered as a bcma device driver. Some
> chipsets fail on SPROM CRC check in the bcma bus driver. This leaves the
> chipset unrecognized and the bcma bus is not registered so that brcmsmac
> is not probed. In particular, the current code .......

All fine with me. To avoid confusion, here is the patch again, with
the above inserted.

Thanks,
Henrik

---

>From 57a4fbd1767b3c2e7c32d288b713e1b06e597bd6 Mon Sep 17 00:00:00 2001
From: Henrik Rydberg <rydberg@...omail.se>
Date: Tue, 31 Jan 2012 14:22:15 -0500
Subject: [PATCH] bcma: don't fail for bad SPROM CRC
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The brcmsmac driver is now registered as a bcma device driver. Some
chipsets fail on SPROM CRC check in the bcma bus driver. This leaves
the chipset unrecognized and the bcma bus is not registered so that
brcmsmac is not probed. In particular, the current code bails out on
recent Macbooks. This patch simply ignores the outcome of the CRC
check, with the argument that an unrecognized SPROM should be treated
similarly to a non-existing one.

Cc: Arend van Spriel <arend@...adcom.com>
Cc: Franky (Zhenhui) Lin <frankyl@...adcom.com>
Cc: Rafał Miłecki <zajec5@...il.com>
Signed-off-by: Henrik Rydberg <rydberg@...omail.se>
Signed-off-by: John W. Linville <linville@...driver.com>
---
 drivers/bcma/main.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
index febbc0a..ec31f7d 100644
--- a/drivers/bcma/main.c
+++ b/drivers/bcma/main.c
@@ -169,10 +169,8 @@ int bcma_bus_register(struct bcma_bus *bus)
 	err = bcma_sprom_get(bus);
 	if (err == -ENOENT) {
 		pr_err("No SPROM available\n");
-	} else if (err) {
+	} else if (err)
 		pr_err("Failed to get SPROM: %d\n", err);
-		return -ENOENT;
-	}
 
 	/* Register found cores */
 	bcma_register_cores(bus);
-- 
1.7.9

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html