netdev - Re: [PATCH] net: sh_eth: fix skb_over

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 07 Feb 2012 17:35:52 +0900
From:	"Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@...esas.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org,
	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
Subject: Re: [PATCH] net: sh_eth: fix skb_over_panic happen

Hi Eric,

2012/02/07 16:55, Eric Dumazet wrote:
> Le mardi 07 février 2012 à 15:54 +0900, Shimoda, Yoshihiro a écrit :
[ snip ]
>> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
>> index 813d41c..9e899b0 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -817,7 +817,7 @@ static int sh_eth_dev_init(struct net_device *ndev)
>>  		sh_eth_write(ndev, 0, TRIMD);
>>
>>  	/* Recv frame limit set register */
>> -	sh_eth_write(ndev, RFLR_VALUE, RFLR);
>> +	sh_eth_write(ndev, ndev->mtu + ETH_HLEN + ETH_FCS_LEN, RFLR);
>>
> 
> No VLAN_HDR ?
> 

Thank you for your point.
I forgot care of VLAN. I will add "+ VLAN_HLEN" and submit a patch.

Best regards,
Yoshihiro Shimoda
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html