netdev - Re: [PATCH v4 2/2] Implement IPV6_UNICAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 07 Feb 2012 10:24:48 -0500
From:	Brian Haley <brian.haley@...com>
To:	"Erich E. Hoover" <ehoover@...es.edu>
CC:	Linux Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] Implement IPV6_UNICAST_IF socket option.

On 02/07/2012 12:01 AM, Erich E. Hoover wrote:
> 
> The IPV6_UNICAST_IF feature is the IPv6 compliment to IP_UNICAST_IF.

> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -199,6 +199,7 @@ lookup_protocol:
>  	sk->sk_backlog_rcv	= answer->prot->backlog_rcv;
>  
>  	inet_sk(sk)->pinet6 = np = inet6_sk_generic(sk);
> +	np->ucast_oif	= 0;
>  	np->hop_limit	= -1;
>  	np->mcast_hops	= IPV6_DEFAULT_MCASTHOPS;
>  	np->mc_loop	= 1;

sk_alloc() will zero the struct, so this is unnecessary.

> --- a/net/ipv6/udp.c
> +++ b/net/ipv6/udp.c
> @@ -1130,6 +1130,9 @@ do_udp_sendmsg:
>  	if (!fl6.flowi6_oif && ipv6_addr_is_multicast(&fl6.daddr)) {
>  		fl6.flowi6_oif = np->mcast_oif;
>  		connected = 0;
> +	} else if (!fl6.flowi6_oif) {
> +		fl6.flowi6_oif = np->ucast_oif;
> +		connected = 0;
>  	}

I don't think you want to clear 'connected' here.

-Brian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html