netdev - Re: [PATCH net-next] gro: more generic L2 header check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Feb 2012 16:31:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	or.gerlitz@...il.com
Cc:	eric.dumazet@...il.com, ogerlitz@...lanox.com,
	sean.hefty@...el.com, herbert@...dor.hengli.com.au,
	linux-rdma@...r.kernel.org, shlomop@...lanox.com,
	roland@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] gro: more generic L2 header check

From: Or Gerlitz <or.gerlitz@...il.com>
Date: Wed, 8 Feb 2012 23:08:26 +0200

> On Wed, Feb 8, 2012 at 10:50 PM, David Miller <davem@...emloft.net> wrote:
>> From: Eric Dumazet <eric.dumazet@...il.com>
>> > Shlomo Pongratz reported GRO L2 header check was suited for Ethernet
>> > only, and failed on IB/ipoib traffic.
>> > He provided a patch faking a zeroed header to let GRO aggregates frames.
>> >
>> > Roland Dreier, Herbert Xu, and others suggested we change GRO L2 header
>> > check to be more generic, ie not assuming L2 header is 14 bytes, but
>> > taking into account hard_header_len.
>> >
>> > __napi_gro_receive() has special handling for the common case (Ethernet)
>> > to avoid a memcmp() call and use an inline optimized function instead.
> 
>> Applied.
> 
> Hi Dave, for correct operation / future bisection, you should 1st
> apply Roland's patch which reduces the hard header len advertized by
> ipoib to be only the size of the ipoib header without that 20 bytes
> headroom, else the gro memcmp will be issued on the ipoib header and
> then 20 bytes of the ip header, kind of back to square one...

I did.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html