lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Feb 2012 08:30:37 +0100 From: Steffen Klassert <steffen.klassert@...unet.com> To: David Miller <davem@...emloft.net> Cc: timo.teras@....fi, netdev@...r.kernel.org Subject: Re: [PATCH 0/4] Fix routing metrics On Mon, Feb 06, 2012 at 03:29:16PM -0500, David Miller wrote: > > Thinking about this, it seems overkill to check this on every metric > access. > > You have an opportunity to validate metrics when the peer is bound to > the route. > > This is because any change to the FIB metrics, is in turn a change > to the FIB, which therefore invalidates the entire routing cache. > > So you can be sure that a new route cache entry will be created, and > at that creation time you can ensure that we'll respect the updated > FIB metrics if encessary. Not sure if I get you right here, but that's what this patchset does. It invalidates the metrics on the peer by incrementing peer_genid in rt_cache_invalidate() which is invoked on every FIB change. Then, on slowpath route lookup it checks in rt_init_metrics() whether the peer_genid changed. If it changed, it exchanges the invalidated merics with new ones and copies the informations from the FIB into it. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists