netdev - RE: [RFC PATCH] rtnetlink: Fix problem with buffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Feb 2012 19:07:15 +0000
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [RFC PATCH] rtnetlink: Fix problem with buffer allocation

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Friday, February 10, 2012 10:52 AM
> To: Rose, Gregory V
> Cc: netdev@...r.kernel.org
> Subject: Re: [RFC PATCH] rtnetlink: Fix problem with buffer allocation
> 
> From: Greg Rose <gregory.v.rose@...el.com>
> Date: Fri, 10 Feb 2012 07:05:18 -0800
> 
> > +/*
> > + * Applications that set NLM_F_EXT have allocated
> > + * a 16K or larger buffer.
> > + * (Or they should have before using this flag)
> > + */
> > +#define NLM_F_EXT	0x800   /* Get extended interface info such as VFs
> */
> 
> This is not what I meant.
> 
> I meant to add a "netlink attribute" that gets passed in with GETLINK
> requests.  Which is a u32 set of flag bits, one bit for each extended
> feature.  So VF would get one bit.
> 
> Like "IFLA_EXT_MASK" or similar.
> 
> Then rtnl_getlink() would inspect the mask (using nla_get_32()), if
> present, and make this control what extended parts of the per-link
> dump are provided.

OK, sounds good.  How about I also add a field to indicate the application buffer size?

- Greg
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html