netdev - Re: [PATCH v8 1/8] sk_run_filter: add support for custom load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Feb 2012 20:22:28 -0600
From:	Will Drewry <wad@...omium.org>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	linux-doc@...r.kernel.org, kernel-hardening@...ts.openwall.org,
	netdev@...r.kernel.org, x86@...nel.org, arnd@...db.de,
	davem@...emloft.net, hpa@...or.com, mingo@...hat.com,
	oleg@...hat.com, peterz@...radead.org, rdunlap@...otime.net,
	mcgrathr@...omium.org, tglx@...utronix.de, luto@....edu,
	eparis@...hat.com, serge.hallyn@...onical.com, djm@...drot.org,
	scarybeasts@...il.com, indan@....nu, pmoore@...hat.com,
	akpm@...ux-foundation.org, corbet@....net, eric.dumazet@...il.com,
	markus@...omium.org, keescook@...omium.org
Subject: Re: [PATCH v8 1/8] sk_run_filter: add support for custom load_pointer

On Thu, Feb 16, 2012 at 7:54 PM, Joe Perches <joe@...ches.com> wrote:
> On Thu, 2012-02-16 at 14:02 -0600, Will Drewry wrote:
>> This change allows CONFIG_SECCOMP to make use of BPF programs for
>> user-controlled system call filtering (as shown in this patch series).
> []
>> diff --git a/net/core/filter.c b/net/core/filter.c
> []
>> @@ -542,9 +602,35 @@ int sk_chk_filter(struct sock_filter *filter, unsigned int flen)
> []
>>               case BPF_S_LD_W_ABS:
>> +                     MAYBE_USE_LOAD_FN(LD_W_ABS);
>>               case BPF_S_LD_H_ABS:
>> +                     MAYBE_USE_LOAD_FN(LD_H_ABS);
>>               case BPF_S_LD_B_ABS:
>> +                     MAYBE_USE_LOAD_FN(LD_B_ABS);
>
> Would be nice to note fallthrough or add break if necessary.

Cool - I'll note it.  They are meant to fall through, but I can just
go back to using goto handle_skb_load or some such so it is more
readable.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html