| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Feb 2012 17:52:30 -0500 (EST) From: David Miller <davem@...emloft.net> To: ben@...servers.co.uk Cc: paulus@...ba.org, netdev@...r.kernel.org, linux-ppp@...r.kernel.org Subject: Re: [PATCH] ppp: fix 'ppp_mp_reconstruct bad seq' errors From: Ben McKeegan <ben@...servers.co.uk> Date: Fri, 24 Feb 2012 16:33:56 +0000 (GMT) > > This patch fixes a (mostly cosmetic) bug introduced by the patch > 'ppp: Use SKB queue abstraction interfaces in fragment processing' > found here: http://www.spinics.net/lists/netdev/msg153312.html > > The above patch rewrote and moved the code responsible for cleaning > up discarded fragments but the new code does not catch every case > where this is necessary. This results in some discarded fragments > remaining in the queue, and triggering a 'bad seq' error on the > subsequent call to ppp_mp_reconstruct. Fragments are discarded > whenever other fragments of the same frame have been lost. > This can generate a lot of unwanted and misleading log messages. > > This patch also adds additional detail to the debug logging to > make it clearer which fragments were lost and which other fragments > were discarded as a result of losses. (Run pppd with 'kdebug 1' > option to enable debug logging.) > > Signed-off-by: Ben McKeegan <ben@...servers.co.uk> I'll apply this, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists