lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Feb 2012 17:15:30 +0300 From: "Anton 'EvilMan' Danilov" <littlesmilingcloud@...il.com> To: jhs@...atatu.com Cc: netdev@...r.kernel.org Subject: Re: [PATCH iproute2] pedit action: add mask for changing bits. Hi, Jamal. 2012/2/27 jamal <hadi@...erus.ca>: > > Looks like a reasonable feature to have - but it has to continue working > as before for things that dont need the mask. > >> >> diff --git a/tc/m_pedit.c b/tc/m_pedit.c >> index 7499846..f081eff 100644 >> --- a/tc/m_pedit.c >> +++ b/tc/m_pedit.c > >> >> tkey->val = htonl(tkey->val & retain); >> - tkey->mask = htonl(tkey->mask | ~retain); >> + tkey->mask = htonl(~tkey->mask | ~retain); > > A change like the above worries me that this may work for your use case > but will break other things that used to work. I'd like to run some > tests but dont have the cycles for the next few days. Alternatively, I > could explain some tests to you and you could validate and fix whatever > breaks. > Let me know what is best for you. > Can You explain tests to me? I'll check behavior with my changes and fix breaks -- Anton. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists