netdev - RE: [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Feb 2012 16:28:48 +0000
From:	"N, Mugunthan V" <mugunthanvnm@...com>
To:	Peter Korsgaard <jacmet@...site.dk>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver

Peter Korsgaard

> -----Original Message-----
> From: Peter Korsgaard [mailto:jacmet@...il.com] On Behalf Of Peter
> Korsgaard
> Sent: Wednesday, February 29, 2012 6:45 PM
> To: N, Mugunthan V
> Cc: netdev@...r.kernel.org; davem@...emloft.net
> Subject: Re: [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver
> 
> >>>>> "M" == Mugunthan V N <mugunthanvnm@...com> writes:
> 
> Hi,
> 
[...]
>  M> +++ b/include/linux/platform_data/cpsw.h
[...]
> 
> Is this really platform specific data (rather than SoC specific)? If
> it's purely a difference between 335x and 814x just use an id_table with
> different platform device names instead.

Instead of driver maintaining the SoC specific offsets, SoC specific files in arch/arm/mach-omap2/ can hold this. Another reason is currently this IP is present in 2 SoCs, there are other SoC coming up where the offsets may change.

> 
> --
> Bye, Peter Korsgaard

With regards
Mugunthan V N
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html