netdev - Re: [PATCH] Bluetooth: Silence static checker warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 02 Mar 2012 09:57:06 -0800
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	David Laight <David.Laight@...LAB.COM>,
	santosh nayak <santoshprasadnayak@...il.com>,
	padovan@...fusion.mobi, davem@...emloft.net,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Ville Tervo <ville.tervo@...ia.com>
Subject: Re: [PATCH] Bluetooth: Silence static checker warning.

Hi Dan,

> > How long has this code been in tree?
> > It isn't obvious to me that this change won't break code on BE systems
> > where the application code is already fixing the endianness.
> > 
> 
> It looks like we've had an endian bug since last February.
> 
> b62f328b8f20a "Bluetooth: Add server socket support for LE
> connection"
> 
> +               l2cap_pi(sk)->scid = la.l2_cid;
> 
> ->scid was cpu endian.

this is a bug. No questions asked.

However you can only exercise this code if you work with Bluetooth Low
Energy and that is not enabled by default since it is not fully finished
yet. CID is only used by Low Energy.

Bluetooth BR/EDR only uses PSM part of the socket address and that has
been endian safe.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html