netdev - Re: [PATCH] tcp: don't fragment SACKed skbs in tcp_mark_head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 03 Mar 2012 14:58:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nanditad@...gle.com
Cc:	ncardwell@...gle.com, netdev@...r.kernel.org,
	ilpo.jarvinen@...sinki.fi, ycheng@...gle.com, therbert@...gle.com
Subject: Re: [PATCH] tcp: don't fragment SACKed skbs in tcp_mark_head_lost()

From: Nandita Dukkipati <nanditad@...gle.com>
Date: Sat, 3 Mar 2012 10:03:56 -0800

> On Fri, Mar 2, 2012 at 11:36 PM, Neal Cardwell <ncardwell@...gle.com> wrote:
>>
>> In tcp_mark_head_lost() we should not attempt to fragment a SACKed skb
>> to mark the first portion as lost. This is for two primary reasons:
>>
>> (1) tcp_shifted_skb() coalesces adjacent regions of SACKed skbs. When
>> doing this, it preserves the sum of their packet counts in order to
>> reflect the real-world dynamics on the wire. But given that skbs can
>> have remainders that do not align to MSS boundaries, this packet count
>> preservation means that for SACKed skbs there is not necessarily a
>> direct linear relationship between tcp_skb_pcount(skb) and
>> skb->len. Thus tcp_mark_head_lost()'s previous attempts to fragment
>> off and mark as lost a prefix of length (packets - oldcnt)*mss from
>> SACKed skbs were leading to occasional failures of the WARN_ON(len >
>> skb->len) in tcp_fragment() (which used to be a BUG_ON(); see the
>> recent "crash in tcp_fragment" thread on netdev).
>>
>> (2) there is no real point in fragmenting off part of a SACKed skb and
>> calling tcp_skb_mark_lost() on it, since tcp_skb_mark_lost() is a NOP
>> for SACKed skbs.
>>
>> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> 
> Acked-by: Nandita Dukkipati <nanditad@...gle.com>

Applied and queued up for -stable, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html