| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 07 Mar 2012 12:53:28 +0100 From: Roland Stigge <stigge@...com.de> To: Arnd Bergmann <arnd@...db.de> CC: davem@...emloft.net, jeffrey.t.kirsher@...el.com, alexander.h.duyck@...el.com, eilong@...adcom.com, ian.campbell@...rix.com, netdev@...r.kernel.org, w.sang@...gutronix.de, linux-kernel@...r.kernel.org, kevin.wells@....com, linux-arm-kernel@...ts.infradead.org, baruch@...s.co.il, joe@...ches.com Subject: Re: [PATCH v5] lpc32xx: Added ethernet driver Hi Arnd, On 03/06/2012 10:34 PM, Arnd Bergmann wrote: > This should eventually both become run-time options based on the device tree. > I don't know if you planned to do that anyway, but if you want the same kernel > binary to be used for systems in different configurations, you cannot have > compile-time decisions that are exclusive-or. Since you don't support device > tree yet but plan to do that in the future, you could add a comment here > about it, or you could even prepare it for that case already by passing the > device into the functions that will be required for reading the properties. Good point. I prefer putting a comment for now, because upon the planned device tree introduction in lpc32xx, an internal change in lpc_eth.c will be necessary anyway, so there is no need to already introduce unused parameters at this point. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists