netdev - Re: [PATCH] mpc836x: fix failed phy detection for ucc ethernet on MDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 Mar 2012 14:36:33 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	afleming@...escale.com, benh@...nel.crashing.org,
	netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] mpc836x: fix failed phy detection for ucc ethernet on MDS


On Feb 27, 2012, at 6:25 AM, Paul Gortmaker wrote:

> The mpc836x_mds platform has been broken since the commit
> 6fe3264945ee63292cdfb27b6e95bc52c603bb09
> 
>  "netdev/phy: Use mdiobus_read() so that proper locks are taken"
> 
> which caused the fsl_pq_mdio TBI autoprobe to oops.  The oops
> was "fixed" in commit 28d8ea2d568534026ccda3e8936f5ea1e04a86a1
> 
>  "fsl_pq_mdio: Clean up tbi address configuration"
> 
> by simply removing the the autoscan code, and making tbi nodes
> mandatory.  Some of the newer reference platforms were updated
> to have tbi nodes in 220669495bf8b68130a8218607147c7b74c28d2b
> 
>  "powerpc: Add TBI PHY node to first MDIO bus"
> 
> but the older mpc836x didn't get one and hence was just failing
> with -EBUSY as follows:
> 
> fsl-pq_mdio: probe of e0102120.mdio failed with error -16
>   ...
> net eth0: Could not attach to PHY
> eth0: Cannot initialize PHY, aborting.
> 
> Add a TBI node and use the 1st free address for it.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---

applied

- k

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html