lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Mar 2012 10:08:46 +0100 From: Oliver Neukum <oneukum@...e.de> To: Ming Lei <tom.leiming@...il.com> Cc: Alan Stern <stern@...land.harvard.edu>, netdev@...r.kernel.org, linux-usb@...r.kernel.org, Fedora Kernel Team <kernel-team@...oraproject.org>, Dave Jones <davej@...hat.com> Subject: Re: use-after-free in usbnet Am Mittwoch, 21. März 2012, 17:22:59 schrieb Ming Lei: > - > + usb_get_urb(urb); > spin_unlock_irqrestore(&q->lock, flags); > // during some PM-driven resume scenarios, > // these (async) unlinks complete immediately > @@ -597,6 +597,7 @@ static int unlink_urbs (struct usbnet *dev, struct > sk_buff_head *q) > netdev_dbg(dev->net, "unlink urb err, %d\n", retval); > else > count++; > + usb_put_urb(urb); Hi, this looks good, but could you add a comment explaining the reason for taking a reference? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists