netdev - Re: [PATCH] net: add a truesize parameter to skb_add_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 24 Mar 2012 02:57:28 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	Wey-Yi Guy <wey-yi.w.guy@...el.com>
Subject: Re: [PATCH] net: add a truesize parameter to skb_add_rx_frag()

Le vendredi 23 mars 2012 à 06:17 -0700, Eric Dumazet a écrit :
> skb_add_rx_frag() API is misleading.
> 
> Network skbs built with this helper can use uncharged kernel memory and
> eventually stress/crash machine in OOM.
> 
> Add a 'truesize' parameter and then fix drivers in followup patches.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Wey-Yi Guy <wey-yi.w.guy@...el.com>
> ---
>  drivers/net/usb/cdc-phonet.c              |    6 ++++--
>  drivers/net/wireless/iwlegacy/3945.c      |    3 ++-
>  drivers/net/wireless/iwlegacy/4965-mac.c  |    3 ++-
>  drivers/net/wireless/iwlwifi/iwl-agn-rx.c |    2 +-
>  include/linux/skbuff.h                    |    2 +-
>  net/core/skbuff.c                         |    4 ++--
>  6 files changed, 12 insertions(+), 8 deletions(-)

Oh well I missed drivers/usb/gadget/f_phonet.c change, I'll send a v2



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html