netdev - Re: [PATCH] net/garp: avoid infinite loop if attribute already exists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Mar 2012 17:44:32 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	david.ward@...mit.edu
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net/garp: avoid infinite loop if attribute already
 exists

From: David Ward <david.ward@...mit.edu>
Date: Sun, 25 Mar 2012 18:43:56 -0400

> @@ -353,9 +361,9 @@ int garp_request_join(const struct net_device *dev,
>  
>  	spin_lock_bh(&app->lock);
>  	attr = garp_attr_create(app, data, len, type);
> -	if (!attr) {
> +	if (IS_ERR(attr)) {
>  		spin_unlock_bh(&app->lock);
> -		return -ENOMEM;
> +		return ERR_PTR(attr);

You cannot tell me that this ERR_PTR() thing didn't emit a very loud
warning from the compiler.  You want PTR_ERR() instead.

Please don't be so careless, if I can predict compiler warnings just
by reading your patches you are so doing it wrong.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html