netdev - Re: [PATCH v5 2/2] Ethernet driver for the WIZnet W5100 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 31 Mar 2012 15:52:37 +0600
From:	Mike Sinkovsky <msink@...monline.ru>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] Ethernet driver for the WIZnet W5100 chip

30.03.2012 15:23, Eric Dumazet написал:

>> +static int w5100_start_tx(struct sk_buff *skb, struct net_device *ndev)
>> +{
>> +	struct w5100_priv *priv = netdev_priv(ndev);
>> +	u16 offset;
>> +
>> +	if (w5100_read16(priv, W5100_S0_TX_FSR)<  skb->len) {
>
> There is a race here.
> Interrupt came come right here before you set the stop_queue()
>
>> +		netif_stop_queue(ndev);
>
> So Here I suggest adding a test again
> 	
> 	if (w5100_read16(priv, W5100_S0_TX_FSR)>= skb->len)
> 		netif_wake_queue(ndev);
> 	else
> 		return NETDEV_TX_BUSY;
>
>> +		return NETDEV_TX_BUSY;

Maybe, but I cannot test this, sorry - when I set breakpoint on this 
branch - it never triggered, on all my tests on all boards.
Appears that my processor is too slow and cannot feed packets fast enough.

But will do, maybe it triggers for someone on fastest processors.

-- 
Mike

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html