[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 04 Apr 2012 09:57:26 -0700
From: Jay Vosburgh <fubar@...ibm.com>
To: Or Gerlitz <ogerlitz@...lanox.com>
cc: davem@...emloft.net, roland@...nel.org, netdev@...r.kernel.org,
Shlomo Pongratz <shlomop@...lanox.com>
Subject: Re: [PATCH net V1 1/2] net/bonding: emit address change event also in bond_release
Or Gerlitz <ogerlitz@...lanox.com> wrote:
>From: Shlomo Pongratz <shlomop@...lanox.com>
>
>commit 7d26bb103c4 "bonding: emit event when bonding changes MAC" didn't
>take care to emit the NETDEV_CHANGEADDR event in bond_release, where bonding
>actually changes the mac address (to all zeroes). As a result the neighbours
>aren't deleted by the core networking code (which does so upon getting that
>event).
>
>Signed-off-by: Shlomo Pongratz <shlomop@...lanox.com>
Signed-off-by: Jay Vosburgh <fubar@...ibm.com>
>---
> drivers/net/bonding/bond_main.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index a20b585..d38f635 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -2035,6 +2035,9 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
> write_unlock_bh(&bond->lock);
> unblock_netpoll_tx();
>
>+ if (bond->slave_cnt == 0)
>+ call_netdevice_notifiers(NETDEV_CHANGEADDR, bond->dev);
>+
> bond_compute_features(bond);
> if (!(bond_dev->features & NETIF_F_VLAN_CHALLENGED) &&
> (old_features & NETIF_F_VLAN_CHALLENGED))
>--
>1.7.1
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists