netdev - Re: [PATCH 1/2] igb: fix rtnl race in PM resume path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Apr 2012 16:02:42 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Benjamin Poirier <bpoirier@...e.de>
Cc:	Alex Duyck <alexander.h.duyck@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	e1000-devel@...ts.sourceforge.net,
	Emil Tantilov <emil.s.tantilov@...el.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Greg Rose <gregory.v.rose@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [PATCH 1/2] igb: fix rtnl race in PM resume path

On Thu, 2012-04-05 at 11:11 -0400, Benjamin Poirier wrote:
> Since the caller (PM resume code) is not the one holding rtnl, when
> taking the
> 'else' branch rtnl may be released at any moment, thereby defeating
> the whole
> purpose of this code block.
> 
> Signed-off-by: Benjamin Poirier <bpoirier@...e.de>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c |   20 ++++++--------------
>  1 files changed, 6 insertions(+), 14 deletions(-) 

Thanks Benjamin, I will add the patch to my igb queue of patches.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)