| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Apr 2012 10:29:41 +0800 From: Gao feng <gaofeng@...fujitsu.com> To: "Eric W. Biederman" <ebiederm@...ssion.com> CC: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, "Serge E. Hallyn" <serge@...lyn.com>, pablo@...filter.org, Stephen Hemminger <shemminger@...tta.com>, Pavel Emelyanov <xemul@...nvz.org> Subject: Re: [PATCH net-next 05/19] net: Move all of the network sysctls without a namespace into init_net. 于 2012年04月23日 09:50, Eric W. Biederman 写道: > Gao feng <gaofeng@...fujitsu.com> writes: > >> 于 2012年04月20日 07:24, Eric W. Biederman 写道: >>> >>> This makes it clearer which sysctls are relative to your current network >>> namespace. >>> >>> This makes it a little less error prone by not exposing sysctls for the >>> initial network namespace in other namespaces. >>> >>> This is the same way we handle all of our other network interfaces to >>> userspace and I can't honestly remember why we didn't do this for >>> sysctls right from the start. >>> >>> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com> >>> --- >>> drivers/infiniband/core/ucma.c | 4 ++-- >>> net/802/tr.c | 2 +- >>> net/appletalk/sysctl_net_atalk.c | 4 ++-- >>> net/ax25/sysctl_net_ax25.c | 4 ++-- >>> net/bridge/br_netfilter.c | 4 ++-- >>> net/core/neighbour.c | 2 +- >>> net/core/sysctl_net_core.c | 2 +- >>> net/dccp/sysctl.c | 4 ++-- >>> net/decnet/dn_dev.c | 4 ++-- >>> net/decnet/sysctl_net_decnet.c | 4 ++-- >>> net/ipv4/netfilter/ip_queue.c | 6 +++--- >>> net/ipv4/route.c | 2 +- >>> net/ipv4/sysctl_net_ipv4.c | 4 ++-- >>> net/ipv6/netfilter/ip6_queue.c | 6 +++--- >>> net/ipv6/netfilter/nf_conntrack_reasm.c | 4 ++-- >>> net/ipv6/sysctl_net_ipv6.c | 2 +- >>> net/ipx/sysctl_net_ipx.c | 5 +++-- >>> net/irda/irsysctl.c | 4 ++-- >>> net/llc/sysctl_net_llc.c | 5 +++-- >>> net/netfilter/nf_conntrack_proto.c | 4 ++-- >> >> Hi Eric >> >> actually,I'm working on making the sysctl and data of nf_conntrack proto pernet, >> and I think it's necessary,without the pernet proto timeout,we can't control >> the container's conntrack timeout unless we change the host's timeout. >> >> maybe somebody want the conntracks in container expired quickly. >> So I will keep on doing this job base on your patchset. >> >> what's your comment? > > My quick skim of your patches suggested to me you are doing useful work. > > Making sysctls that are not pernet init_net only serve two > purposes. > - Prevent mistakes by changing a sysctl you think is pernet but globally > affects the networking stack. > - Make it easy to find which sysctls need to be converted. OK,I got it. > > I suspect a lot of sysctls have not been converted simply because no one > realized they had not been converted. > > I hope my code cleanup did not set you back very much. I don't believe > there were any conflicts in principle just a few places where we touched > the same code. Yes,just a little of codes,Thanks for your comments. Thanks, Gao > > Eric > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists