lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 03 May 2012 09:52:45 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Alexander Duyck <alexander.h.duyck@...el.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, jeffrey.t.kirsher@...el.com, edumazet@...gle.com Subject: Re: [v2 PATCH 3/4] tcp: move stats merge to the end of tcp_try_coalesce On Thu, 2012-05-03 at 00:19 -0700, Alexander Duyck wrote: > This change cleans up the last bits of tcp_try_coalesce so that we only > need one goto which jumps to the end of the function. The idea is to make > the code more readable by putting things in a linear order so that we start > execution at the top of the function, and end it at the bottom. > > I also made a slight tweak to the code for handling frags when we are a > clone. Instead of making it an if (clone) loop else nr_frags = 0 I changed > the logic so that if (!clone) we just set the number of frags to 0 which > disables the for loop anyway. > > Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com> > Cc: Eric Dumazet <edumazet@...gle.com> > Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com> > --- > > net/ipv4/tcp_input.c | 55 ++++++++++++++++++++++++++------------------------ > 1 files changed, 29 insertions(+), 26 deletions(-) Thanks a lot Alex, this patch serie looks very good. Acked-by: Eric Dumazet <edumazet@...gle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists