lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 04 May 2012 15:04:56 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Jiri Bohac <jbohac@...e.cz> Cc: David Miller <davem@...emloft.net>, fubar@...ibm.com, andy@...yhouse.net, netdev@...r.kernel.org Subject: Re: [PATCH v2] bonding: don't increase rx_dropped after processing LACPDUs On Fri, 2012-05-04 at 14:19 +0200, Jiri Bohac wrote: > Since commit 3aba891d, bonding processes LACP frames (802.3ad > mode) with bond_handle_frame(). Currently a copy of the skb is > made and the original is left to be processed by other > rx_handlers and the rest of the network stack by returning > RX_HANDLER_ANOTHER. As there is no protocol handler for > PKT_TYPE_LACPDU, the frame is dropped and dev->rx_dropped > increased. > > Fix this by making bond_handle_frame() return RX_HANDLER_CONSUMED > if bonding has processed the LACP frame. > > Signed-off-by: Jiri Bohac <jbohac@...e.cz> > > if (likely(nskb)) { > - recv_probe(nskb, bond, slave); > + ret = recv_probe(nskb, bond, slave); > dev_kfree_skb(nskb); > + if (ret == RX_HANDLER_CONSUMED) { > + kfree_skb(skb); consume_skb(skb) to not fool drop_monitor/dropwatch ? > + return ret; > + } > } > } -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists