netdev - Re: [PATCH 01/13 v4] usb/net: rndis: inline the cpu_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 5 May 2012 11:01:42 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Felipe Balbi <balbi@...com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH 01/13 v4] usb/net: rndis: inline the cpu_to_le32() macro

On Wed, May 2, 2012 at 5:29 PM, Jussi Kivilinna
<jussi.kivilinna@...et.fi> wrote:

> Quoting Linus Walleij <linus.walleij@...aro.org>:
>
>> The header file <linux/usb/rndis_host.h> used a number of #defines
>> that included the cpu_to_le32() macro to assure the result will be
>> in LE endianness. Inlining this into the code instead of using it
>> in the code definitions yields consolidation opportunities later
>> on as you will see in the following patches. The individual
>> drivers also used local defines - all are switched over to the
>> pattern of doing the conversion at the call sites instead.
>>
>
> After this patch, endianness checks with sparse output:
(...)
> Patch fixing this attached.

Thanks! Folded this into patch 1 and added your Signed-off-by.

> Patch-set to clean-up ugliness caused by this patch at:
> http://koti.mbnet.fi/axh/kernel/rndis_wlan/

This seems like a good middle-ground as compared to the
other suggestion to force all defines to be cpu_to_le32().

Do you want me to rebase this on top of my series (there was
a number of conflicts later in the series) and carry it as part
of this patch set?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html