lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 May 2012 15:13:57 +0900 From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@...esas.com> To: Ben Hutchings <bhutchings@...arflare.com> Cc: netdev <netdev@...r.kernel.org>, SH-Linux <linux-sh@...r.kernel.org> Subject: Re: [PATCH v2 5/5] net: sh_eth: use NAPI 2012/05/12 0:35, Ben Hutchings wrote: > On Fri, 2012-05-11 at 17:38 +0900, Shimoda, Yoshihiro wrote: >> This patch modifies the driver to use NAPI. > [...] >> +static int sh_eth_poll(struct napi_struct *napi, int budget) >> +{ < snip > >> + /* check whether the controller doesn't have any events */ >> + if (!txfree_num && !(intr_status & cd->eesr_err_check) && >> + work_done < budget) { >> + napi_complete(napi); > > If and only if you return a value less than the budget then you *must* > call napi_complete(). You can't add these extra conditions. Thank you for the point. I will fix it. < snip > > > You will also need to call napi_disable() and napi_enable() in the > set_ringparam implementation. I will add the code in sh_eth_set_ringparam(). > Ben. > Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists