lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 May 2012 01:16:15 -0400 (EDT) From: David Miller <davem@...emloft.net> To: kkeil@...ux-pingi.de Cc: netdev@...r.kernel.org Subject: Re: [PATCH 3/8] mISDN: avmfritz use the bigger fifo of chip version 2 From: Karsten Keil <kkeil@...ux-pingi.de> Date: Wed, 16 May 2012 06:22:49 +0200 > + mode = (AVM_FRITZ_PCIV2 == fc->type) ? HDLC_FIFO_SIZE_128 : 0; Please don't do this "CONSTANT == variable" type testing order, it's completely unnatural and not something we commonly do elsewhere in the networking code. I know some coders bible somewhere says that this is how you avoid accidental assignments, but it's too ugly to live. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists