netdev - Re: [PATCH 1/1] smsc95xx: add FLAG_POINTTOPOINT flag for driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 May 2012 16:20:47 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Xiao Jiang <jgq516@...il.com>
Cc:	steve.glendinning@...c.com, gregkh@...uxfoundation.org,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] smsc95xx: add FLAG_POINTTOPOINT flag for driver_info

On Thu, May 17, 2012 at 10:23 AM, Xiao Jiang <jgq516@...il.com> wrote:
> Ming Lei wrote:
>>
>> On Wed, May 16, 2012 at 4:01 PM,  <jgq516@...il.com> wrote:
>>
>>>
>>> From: Xiao Jiang <jgq516@...il.com>
>>>
>>> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
>>> which possibly use "usb%d" names, add this flag to make sure pandaboard
>>> can mount nfs with smsc95xx NIC.
>>>
>>
>>
>> Without the flag, I also can mount nfs successfully on my Pandaboard...

I always mount nfs in console, and not tried to mount nfs as root fs.

>>
>>
>
> I have pulled latest tree
> (git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> commit 0e93b4b304ae052ba1bc73f6d34a68556fe93429), and enable related options
> (USB_NET_SMSC95XX,
> USB_EHCI_HCD and USB_EHCI_HCD_OMAP) with omap2plus_config, However the
> kernel still can't mount
> nfs, pls see below infos.
>
> [    3.114105] smsc95xx v1.0.4
> [    4.533752] smsc95xx 1-1.1:1.0: *eth0*: register 'smsc95xx' at
> usb-ehci-omap.0-1.1, smsc95xx USB 2.0 Ethernet, fe:b9:1b:07:8e:d1
> [  108.854217] VFS: Unable to mount root fs via NFS, trying floppy.
> [  108.861114] VFS: Cannot open root device "nfs" or unknown-block(2,0):
> error -6
> [  108.868713] Please append a correct "root=" boot option; here are the
> available partitions:
> [  108.877655] b300         7761920 mmcblk0  driver: mmcblk
> [  108.883239]   b301           40131 mmcblk0p1
> 00000000-0000-0000-0000-000000000mmcblk0p1
> [  108.891662]   b302         7719232 mmcblk0p2
> 00000000-0000-0000-0000-000000000mmcblk0p2
> [  108.900146] Kernel panic - not syncing: VFS: Unable to mount root fs on
> unknown-block(2,0)
>
> BTW: I tested it with OMAP4430 ES2.2 pandaboard, the issue can be solved
> with apply the patch.
>
> Is there something which I missed? thanks.

What is your kernel parameter? Maybe you use 'usb%d' in kernel parameter for
mounting nfs as root fs. If so, could you try 'eth%d' in kernel cmd?

In fact, smsc95xx is a real LAN interface, and 'eth%d' should be prefered name
as described in changelog of commit
c261344d3ce3edac781f9d3c7eabe2e96d8e8fe8(usbnet:use eth%d name for
known ethernet devices)


Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html