netdev - Re: [PATCH] pktgen: fix module unload for good

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 May 2012 13:55:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] pktgen: fix module unload for good

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 18 May 2012 11:52:26 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> commit c57b5468406 (pktgen: fix crash at module unload) did a very poor
> job with list primitives.
> 
> 1) list_splice() arguments were in the wrong order 
> 
> 2) list_splice(list, head) has undefined behavior if head is not
> initialized.
> 
> 3) We should use the list_splice_init() variant to clear pktgen_threads
> list.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html