lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 May 2012 15:15:18 -0500 From: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com> To: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com> CC: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, dledford@...hat.com, Jes.Sorensen@...hat.com Subject: Re: [PATCH resend] rds_rdma: don't assume infiniband device is PCI On 5/28/2012 1:52 PM, Thadeu Lima de Souza Cascardo wrote: > RDS code assumes that the struct ib_device dma_device member, which is a > pointer, points to a struct device embedded in a struct pci_dev. > > This is not the case for ehca, for example, which is a OF driver, and > makes dma_device point to a struct device embedded in a struct > platform_device. > > This will make the system crash when rds_rdma is loaded in a system > with ehca, since it will try to access the bus member of a non-existent > struct pci_dev. > > The only reason rds_rdma uses the struct pci_dev is to get the NUMA node > the device is attached to. Using dev_to_node for that is much better, > since it won't assume which bus the infiniband is attached to. > > Signed-off-by: Thadeu Lima de Souza Cascardo<cascardo@...ux.vnet.ibm.com> > Cc: dledford@...hat.com > Cc: Jes.Sorensen@...hat.com > Cc: Venkat Venkatsubra<venkat.x.venkatsubra@...cle.com> > --- > Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists