lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 May 2012 18:20:01 -0400 (EDT) From: David Miller <davem@...emloft.net> To: shimoda.hiroaki@...il.com Cc: therbert@...gle.com, eric.dumazet@...il.com, denys@...p.net.lb, netdev@...r.kernel.org Subject: Re: [PATCH net 2/3] bql: Avoid unneeded limit decrement. From: Hiroaki SHIMODA <shimoda.hiroaki@...il.com> Date: Thu, 31 May 2012 07:25:19 +0900 > When below pattern is observed, > > TIME > dql_queued() dql_completed() | > a) initial state | > | > b) X bytes queued V > > c) Y bytes queued > d) X bytes completed > e) Z bytes queued > f) Y bytes completed > > a) dql->limit has already some value and there is no in-flight packet. > b) X bytes queued. > c) Y bytes queued and excess limit. > d) X bytes completed and dql->prev_ovlimit is set and also > dql->prev_num_queued is set Y. > e) Z bytes queued. > f) Y bytes completed. inprogress and prev_inprogress are true. > > At f), according to the comment, all_prev_completed becomes > true and limit should be increased. But POSDIFF() ignores > (completed == dql->prev_num_queued) case, so limit is decreased. > > Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@...il.com> Applied and queued up for -stable. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists