lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Jun 2012 05:02:49 +0200 From: Lennert Buytenhek <buytenh@...tstofly.org> To: Josh Boyer <jwboyer@...hat.com> Cc: Andrew Lunn <andrew@...n.ch>, Olof Johansson <olof@...om.net>, Jamie Lentin <jm@...tin.co.uk>, Mike Turquette <mturquette@...aro.org>, netdev@...r.kernel.org Subject: Re: [PATCH] netdev: mv643xx_eth: Prevent build on PPC32 On Tue, Jun 05, 2012 at 10:40:14PM -0400, Josh Boyer wrote: > > > Commit 452503ebc (ARM: Orion: Eth: Add clk/clkdev support.) added use of > > > the clk driver API which results in compile errors on architectures that > > > don't implement the clk API. > > > > > > ERROR: "clk_enable" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined! > > > ERROR: "clk_disable" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined! > > > ERROR: "clk_put" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined! > > > ERROR: "clk_get_rate" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined! > > > ERROR: "clk_get" [drivers/net/ethernet/marvell/mv643xx_eth.ko] undefined! > > > > > > Selecting CLKDEV_LOOKUP doesn't fix this either, as the build then fails with: > > > > > > In file included from drivers/clk/clkdev.c:21:0: > > > include/linux/clkdev.h:15:24: fatal error: asm/clkdev.h: No such file or directory > > > > > > So we just prevent this from building at all on PPC32. > > > > If the PPC32 dependency is no longer relevant (e.g. if Pegasos platform > > support was removed from the kernel), then the commit message should > > mention that -- the above reasoning is a poor sole justification for > > this change. > > You are correct. As it stands, it's no better than just breaking it > outright with commit 452503ebc. ACK. If I'd have seen that commit ("ARM: Orion: Eth: Add clk/clkdev support.") come by I would have said something about it, but noone bothered to CC me on it -- and it doesn't seem that it was CCed to netdev@ either...? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists