[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 06 Jun 2012 01:46:06 -0700
From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
Cc: davem@...emloft.net, denys@...p.net.lb, eric.dumazet@...il.com,
therbert@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] e1000e: Change wthresh to 1 to avoid possible Tx
stalls.
On Wed, 2012-06-06 at 17:43 +0900, Hiroaki SHIMODA wrote:
> Denys Fedoryshchenko reported Tx stalls on e1000e with BQL enabled.
>
> e1000e has WTHRESH which determines when Tx descripters are written
> back and successive Tx interrupts are generated, and setting WTHRESH
> to 5 gives efficient bus utilization but this cause possible Tx
> stalls,
> especially on BQL enabled system.
>
> To avoid possible Tx stalls, change WTHRESH to 1.
>
> Reported-by: Denys Fedoryshchenko <denys@...p.net.lb>
> Tested-by: Denys Fedoryshchenko <denys@...p.net.lb>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
> ---
> drivers/net/ethernet/intel/e1000e/e1000.h | 6 +++---
> drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
Thanks! I will add this to my queue of e1000e patches.
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists