netdev - Re: [PATCH] net: sierra_net: device IDs for Aircard 320U++

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2012 21:16:33 +0900
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Dan Williams <dcbw@...hat.com>, linux@...rrawireless.com,
	Autif Khan <autif.mlist@...il.com>,
	Tom Cassidy <tomas.cassidy@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH] net: sierra_net: device IDs for Aircard 320U++

On Wed, Jun 06, 2012 at 10:19:15AM +0200, Bjørn Mork wrote:
> Greg KH <gregkh@...uxfoundation.org> writes:
> > On Wed, Jun 06, 2012 at 09:18:10AM +0200, Bjørn Mork wrote:
> >> Adding device IDs for Aircard 320U and two other devices
> >> found in the out-of-tree version of this driver.
> >> 
> >> Cc: linux@...rrawireless.com
> >> Cc: Autif Khan <autif.mlist@...il.com>
> >> Cc: Tom Cassidy <tomas.cassidy@...il.com>
> >> Cc: stable@...r.kernel.org
> >> Signed-off-by: Bjørn Mork <bjorn@...k.no>
> >> ---
> >>  drivers/net/usb/sierra_net.c |   14 ++++++++++----
> >>  1 file changed, 10 insertions(+), 4 deletions(-)
> >
> > Wait, Tom just sent me a patch adding these device ids to the sierra
> > serial driver, why would the same device work for both drivers?
> 
> Because it's a composite device.  Was this a trick question? :-)
> 
> >  Where should the device id go?
> 
> To both drivers.  The device is similar to the 1199:68a3 device already
> supported by both drivers.  It has a number of serial ports (depending
> on how many features like GPS etc is enabled) supported by the "sierra"
> driver and one ethernet interface speaking Sierra's HIP protocol
> supported by the "sierra_net" driver.

Ok, thanks for clearing that up, I'll take the serial patch, and I'm
sure that David will take this one.

	Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html