netdev - RE: [net-next PATCH v2 1/3] Added kernel support in EEE Ethtool commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2012 16:40:15 +0000
From:	"Yuval Mintz" <yuvalmin@...adcom.com>
To:	"Ben Hutchings" <bhutchings@...arflare.com>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Eilon Greenstein" <eilong@...adcom.com>,
	"peppe.cavallaro@...com" <peppe.cavallaro@...com>
Subject: RE: [net-next PATCH v2 1/3] Added kernel support in EEE Ethtool
 commands

> > + * @supported: Link speeds for which there is eee support.
> > + * @advertised: Link speeds the interface advertises (AN) as eee capable.
> > + * @lp_advertised: Link speeds the link partner advertised as eee capable.
> 
> And these are bitmasks of SUPPORTED_* & ADVERTISED_* flags, right?

Right.

> Maybe 'link modes' not 'link speeds'?

Not that it matters greatly, but there are SUPPORTED & ADVERTISED flags for
things other than link speeds, such as connection type and flow control,
so using exactly the same semantic in description might confuse someone.

Thank,
Yuval