lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Jun 2012 10:25:08 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Roland Stigge <stigge@...com.de> Cc: davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kevin.wells@....com, srinivas.bakki@....com, aletes.xgr@...il.com, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 1/3] net: lpc_eth: Replace WARN() trace with simple pr_warn() On Mon, 2012-06-11 at 10:03 +0200, Roland Stigge wrote: > A WARN() trace indicating a "BUG!" was identified as a "normal" case in the > xmit function in case all TX descriptors are occupied already. In this case, > NETDEV_TX_BUSY is returned, nothing buggy at all. > > Signed-off-by: Roland Stigge <stigge@...com.de> > Tested-by: Alexandre Pereira da Silva <aletes.xgr@...il.com> > > --- > drivers/net/ethernet/nxp/lpc_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-2.6.orig/drivers/net/ethernet/nxp/lpc_eth.c > +++ linux-2.6/drivers/net/ethernet/nxp/lpc_eth.c > @@ -1114,7 +1114,7 @@ static int lpc_eth_hard_start_xmit(struc > buffers */ > netif_stop_queue(ndev); > spin_unlock_irq(&pldat->lock); > - WARN(1, "BUG! TX request when no free TX buffers!\n"); > + pr_warn("Note: TX request when no free TX buffers.\n"); > return NETDEV_TX_BUSY; > } > Entering this path is a bug, don't hide it... Please share with us how this bug was identified as a "normal case" ? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists