netdev - Re: [PATCH net-next 5/5] net: sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Jun 2012 15:47:00 +0900
From:	"Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@...esas.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	SH-Linux <linux-sh@...r.kernel.org>
Subject: Re: [PATCH net-next 5/5] net: sh_eth: use NAPI

2012/06/12 14:48, Eric Dumazet wrote:
> On Tue, 2012-06-12 at 14:19 +0900, Shimoda, Yoshihiro wrote:
< snip >
>> +	if ((mdp->cur_tx - mdp->dirty_tx) >= (mdp->num_tx_ring - 4)) {
>> +		if (netif_msg_tx_queued(mdp)) {
>> +			dev_warn(&ndev->dev, "TxFD exhausted.\n");
>> +			netif_stop_queue(ndev);
>> +		}
>> +	}
>> +
>>  	return NETDEV_TX_OK;
>>  }
> 
> 
> I have no idea why you call netif_stop_queue() only if
> netif_msg_tx_queued(mdp)
> 
> You should test your driver under heavy TX load.
> 

Thank you for the point.
I checked the netif-msg.txt about netif_msg_tx_queued(). It is one of
the network interface message level setting. So, the driver's behavior
should not be changed by the level, I think.
I will modify the patch.

Best regards,
Yoshihiro Shimoda
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html