netdev - Re: [PATCH] ipv6: Handle PMTU in ICMP error handlers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jun 2012 22:42:25 -0400
From:	Neal Cardwell <ncardwell@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: Handle PMTU in ICMP error handlers.

On Fri, Jun 15, 2012 at 6:00 PM, David Miller <davem@...emloft.net> wrote:
> +++ b/include/net/ip6_route.h
> +extern void ip6_update_pmtu(struct sk_buff *skb, struct net *net, __be32 mtu,
> +                           int oif, u32 mark);
...
> +++ b/net/ipv6/route.c
> +void ip6_update_pmtu(struct sk_buff *skb, struct net *net, u32 mtu,
> +                    int oif, __be32 mark)

The .h and .c files disagree on the types of mtu and mark for
ip6_update_pmtu(). Looks like the mtu should be __be32 in both. I'm
guessing mark should also be __be32 in both, though I'm not yet
familiar with that area of the code.

Otherwise looks great to me.

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html