netdev - Re: [PATCH v3] fec: fix clk handling for Coldfire.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 17 Jun 2012 16:47:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sfking@...dc.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3] fec: fix clk handling for Coldfire.

From: Steven King <sfking@...dc.com>
Date: Sun, 17 Jun 2012 16:39:43 -0700

> commit f4d40de39a23f0c39cca55ac63e1175c69c3d2f7
> 'net fec: do not depend on grouped clocks' broke fec for Coldfire.
> 
> Hide the details of the fec clk management in a trio of new functions: 
> fec_clk_get, fec_clk_prepare and fec_clk_disable_unprepare.  these then can 
> be modified as needed to manage the clks for the different arches that use
> the fec controller.
> 
> Signed-off-by: Steven King <sfking@...dc.com>

I said keep the ifdefs out of the foo.c code.

Put this ifdef'y into one of the driver's header files, such
as fec.h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html