lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Jun 2012 10:57:46 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: santosh nayak <santoshprasadnayak@...il.com> Cc: sony.chacko@...gic.com, rajesh.borundia@...gic.com, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] netxen: Error return off by one in 'netxen_nic_set_pauseparam()'. On Wed, Jun 20, 2012 at 12:57:39PM +0530, santosh nayak wrote: > From: Santosh Nayak <santoshprasadnayak@...il.com> > > There are 'NETXEN_NIU_MAX_GBE_PORTS' GBE ports. Port indexing starts > from zero. > Hence we should also return error for "port == NETXEN_NIU_MAX_GBE_PORTS" > So my understanding is that you are guessing on this based on the fact that, "Who counts from 0-4 inclusive?". I can't argue with that logic. Looking some more at NETXEN_NIU_MAX_XG_PORTS. It is used off by one 4 times and it's used correctly 1 time. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists