netdev - Re: [PATCH] net: dcb: fix small regression in __dcbnl_pg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Jun 2012 04:19:10 -0400
From:	Thomas Graf <tgraf@...radead.org>
To:	John Fastabend <john.r.fastabend@...el.com>
Cc:	tgraf@...g.ch, davem@...emloft.net, netdev@...r.kernel.org,
	lucy.liu@...el.com, alexander.h.duyck@...el.com
Subject: Re: [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()

On Wed, Jun 20, 2012 at 10:56:21PM -0700, John Fastabend wrote:
> A small regression was introduced in the reply command of
> dcbnl_pg_setcfg(). User space apps may be expecting the
> DCB_ATTR_PG_CFG attribute to be returned with the patch
> below TX or RX variants are returned.
> 
> commit 7be994138b188387691322921c08e19bddf6d3c5
> Author: Thomas Graf <tgraf@...g.ch>
> Date:   Wed Jun 13 02:54:55 2012 +0000
> 
>     dcbnl: Shorten all command handling functions
> 
> This patch reverts this behavior and returns DCB_ATTR_PG_CFG
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> ---
> 
>  net/dcb/dcbnl.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
> index 0a36007..013da86 100644
> --- a/net/dcb/dcbnl.c
> +++ b/net/dcb/dcbnl.c
> @@ -852,8 +852,7 @@ static int __dcbnl_pg_setcfg(struct net_device *netdev, struct nlmsghdr *nlh,
>  		}
>  	}
>  
> -	return nla_put_u8(skb,
> -			  (dir ? DCB_CMD_PGRX_SCFG : DCB_CMD_PGTX_SCFG), 0);
> +	return nla_put_u8(skb, DCB_ATTR_PG_CFG, 0);
>  }
>  

ACK

Thanks John
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html