netdev - Re: [PATCH net-next] net: Remove 'unlikely' qualifier in skb_steal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Jun 2012 16:08:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	subramanian.vijay@...il.com, netdev@...r.kernel.org,
	alexander.h.duyck@...el.com, shemminger@...tta.com
Subject: Re: [PATCH net-next] net: Remove 'unlikely' qualifier in
 skb_steal_sock()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 25 Jun 2012 08:09:37 +0200

> On Sun, 2012-06-24 at 16:03 -0700, Vijay Subramanian wrote:
>> With early demux enabled by default for TCP flows, there is high chance that
>> skb->sk will be non-null. 'unlikely()' was removed from __inet_lookup_skb() but
>> maybe it can be removed from skb_steal_sock() as well.
>> 
>> Note: skb_steal_sock() is also called by __inet6_lookup_skb() and
>> __udp4_lib_lookup_skb() but they are protected by their own 'unlikely' calls.
>> 
>> Signed-off-by: Vijay Subramanian <subramanian.vijay@...il.com>
>> ---
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html